Adding a document for installing Athens on ACI #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #967 +/- ##
=======================================
Coverage 54.83% 54.83%
=======================================
Files 79 79
Lines 2639 2639
=======================================
Hits 1447 1447
Misses 1073 1073
Partials 119 119Continue to review full report at Codecov.
|
michalpristas
approved these changes
Dec 20, 2018
|
|
||
| ## Selecting a Storage Provider | ||
|
|
||
| Athens currently supports a number of storage drivers. For quick and easy use on ACI, we recommend using the local disk provider. For more permanend use, we recommend using MongoDB or other more persistent infrastructure. For other providers, please see the [storage provider documentation](/configuration/storage/). |
|
|
||
| ### Installing with the MongoDB Storage Driver | ||
|
|
||
| First make sure you have the following environment variable set up: |
| @@ -10,7 +10,7 @@ We will use Docker to run the Athens proxy, so first make sure you have Docker [ | |||
|
|
|||
| ## Selecting a Storage Provider | |||
|
|
|||
| Athens currently supports a number of storage drivers. For local use we recommend starting with the local disk provider. For other providers, please see the Storage Provider documentation [Coming Soon]. | |||
| Athens currently supports a number of storage drivers. For local use we recommend starting with the local disk provider. For other providers, please see the [storage provider documentation](/configuration/storage/). | |||
There was a problem hiding this comment.
s/For local use we recommend/For local use, we recommend
but not sure about that
There was a problem hiding this comment.
sounds better to me with the comma too 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
There were no docs on how to install Athens on Azure Container Instances
How is the fix applied?
I added a document describing how to install Athens on Azure Container Instances
Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
Fixes #57