Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about SSH_AUTH_SOCK from PR#1184 #1185

Merged
merged 5 commits into from
Apr 30, 2019
Merged

Add documentation about SSH_AUTH_SOCK from PR#1184 #1185

merged 5 commits into from
Apr 30, 2019

Conversation

dfinkel
Copy link
Contributor

@dfinkel dfinkel commented Apr 12, 2019

#1184 added support for propagating SSH_AUTH_SOCK if it points to a
valid unix socket. As requested by @arschles, add a section explaining how to use
it.

While I'm touching the documentation, also protect references to the current working directory by converting $(pwd) to quoted references to the $PWD pseudo-environment variable, which avoids issues with word-splitting in bash and most other sh-compatible shells.

dfinkel added 2 commits April 12, 2019 15:31
PR#1184 added support for propagating SSH_AUTH_SOCK if it points to a
valid unix socket. As requested, add a section explaining how to use
it.
Replace references to `$(pwd)` with `$PWD` in shell snippets and add
more quoting. This should make these snippets reasonably friendly to
currnet working directory path components containing spaces.

Note: I neither endorse nor recommend spaces in directories, but this is
an easy enough change.

This commit is leaving powershell snippets untouched as I am not
familiar with powershell's word-splitting behavior (if there is any).
@dfinkel dfinkel requested a review from a team as a code owner April 12, 2019 19:38
Copy link
Member

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfinkel this looks great. Thanks for the clear documentation too!

🎉 :shipit: 🚀

@manugupt1 manugupt1 merged commit 0be1cd9 into gomods:master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants