Refactoring the developer meetings page #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this works locally but I have no idea why...
where it's really Friday FEEL THE PAIN
chriscoffee
approved these changes
Apr 10, 2019
manugupt1
reviewed
Apr 11, 2019
docs/static/js/dev-meetings.js
Outdated
|
|
||
| // get next thursday in moment format for each time | ||
| // (so that we can more easily print it out) | ||
| const time20 = moment(). |
There was a problem hiding this comment.
I can't see this being used anywhere.
docs/static/js/dev-meetings.js
Outdated
| } else { | ||
| time22ID.innerHTML = time22Str + " (Friday)"; | ||
| } | ||
| // const tz = jstz.guess(); |
There was a problem hiding this comment.
Can you clean up comments as it is confusing?
|
Thanks for the reviews @chriscoffee and @manugupt1 ! @manugupt1 I addressed your feedback. Can you take another look when you have time? |
manugupt1
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
The developer meetings page was a little bit unclear, and it didn't show the rotating times for the meetings properly. Folks also had trouble converting UTC to their own time zone.
How is the fix applied?
I tried to make the developer meetings page clearer and put in some JS code to guess the time zone. I have no idea what I'm doing though...
Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
N/A