Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation for Chinese #1112

Merged
merged 7 commits into from
Mar 12, 2019
Merged

Add translation for Chinese #1112

merged 7 commits into from
Mar 12, 2019

Conversation

LinuxSuRen
Copy link
Contributor

No description provided.

@LinuxSuRen LinuxSuRen requested a review from a team as a code owner March 8, 2019 02:47
@codecov-io
Copy link

codecov-io commented Mar 8, 2019 •
edited
Loading

Codecov Report

Merging #1112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1112   +/-   ##
======================================
  Coverage    53.1%   53.1%           
======================================
  Files          80      80           
  Lines        2785    2785           
======================================
  Hits         1479    1479           
  Misses       1178    1178           
  Partials      128     128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4450c1...be703e7. Read the comment docs.

marpio
marpio reviewed Mar 8, 2019
View reviewed changes
Copy link
Member

@marpio marpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome @LinuxSuRen Thank you very much for that!

@michalpristas
Copy link
Member

This is awesome, let me check the channel for another Chinese speaking person to do a review.

hihilary
hihilary reviewed Mar 8, 2019
View reviewed changes
@chriscoffee
Copy link
Member

Thanks for making those corrections!

@arschles arschles requested a review from marpio March 12, 2019 19:12
arschles
arschles approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@arschles arschles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you @LinuxSuRen and @hihilary for your translation and proofreading!

🎉 :shipit: 😁

@arschles arschles merged commit 59363b4 into gomods:master Mar 12, 2019
@LinuxSuRen LinuxSuRen deleted the index branch March 13, 2019 01:28
@LinuxSuRen
Copy link
Contributor Author

Athens is pretty cool. I'm going to translate all the documents if I have enough time.

@arschles arschles mentioned this pull request Mar 13, 2019
Merged
@arschles
Copy link
Member

@LinuxSuRen, I'm really glad to hear that! You're welcome to do any contributions you like 😁

@michalpristas michalpristas added awaiting review The PR has been triaged and is ready for someone to review. localization Improving localization on our docs, log output, and so on and removed awaiting review The PR has been triaged and is ready for someone to review. labels Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscoffee chriscoffee chriscoffee left review comments

@hihilary hihilary hihilary left review comments

@arschles arschles arschles approved these changes

@marpio marpio Awaiting requested review from marpio

Assignees
No one assigned
Labels
localization Improving localization on our docs, log output, and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LinuxSuRen @codecov-io @michalpristas @chriscoffee @arschles @marpio @hihilary