Further alterations to the install documentation #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to gomods#1095. I accidentally merged that :( so I am rolling forward here based on comments in the previous PR
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
=======================================
Coverage 53.05% 53.05%
=======================================
Files 80 80
Lines 2731 2731
=======================================
Hits 1449 1449
Misses 1163 1163
Partials 119 119Continue to review full report at Codecov.
|
marpio
approved these changes
Mar 5, 2019
marwan-at-work
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
The docs don't say what happens if the upstream repository owner changes git tags, overwrites commits, deletes their repo, etc...
How is the fix applied?
I added documentation that explains how Athens stores modules in write-once storage
Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
Fixes #1054
This is a follow-up to #1095. I accidentally merged that :( so I am rolling forward here based on comments in the previous PR
@MMulthaupt @michalpristas @marpio I'm really sorry for the trouble but would you mind re-reviewing this? I really messed up but it turned out that making additional changes was easier (for me!) than reverting and re-submitting. Thank you so much!