Version filtering #1050
Merged
Version filtering #1050
+109
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module filtering is very useful, but many deployments will need to satisfy even more granular constrainsts. Enterprises may need approved lists specific down to the minor (or patch) version element. Version filtering logic is similar to the module filtering, in that it's a prefix match of the version requested against each entry in the version filter list. Closes gomods#1045
Kunde21
force-pushed
the
1045-version_filter
branch
from
b370c33 to
7d6e746
Compare
Endpoints that do not specify a version, such as "@v/list", only need to be filtered by module rules.
Codecov Report
@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
+ Coverage 52.96% 53.34% +0.38%
==========================================
Files 79 79
Lines 2562 2583 +21
==========================================
+ Hits 1357 1378 +21
Misses 1092 1092
Partials 113 113
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Increase the granularity of module filtering to include version matching.
How is the fix applied?
A comma-separated list of version filters is parsed from the filter rule, separated from the module by a space. These version filters are applied using a prefix match, similar to the module filtering.
Documentation has been updated, with an example filter file using version filtering.
Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
Fixes #1045