Add text length #116
Merged
Add text length #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 82.42% 82.82% +0.39%
==========================================
Files 34 35 +1
Lines 1178 1205 +27
==========================================
+ Hits 971 998 +27
Misses 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
faneshion
reviewed
Sep 25, 2024
|
|
||
| # Metrics about the answer informativeness | ||
|
|
There was a problem hiding this comment.
建议文件夹的名字写”answer_informativeness“
|
|
||
| def __repr__(self) -> str: | ||
| """:return: Formatted string representation of the metric.""" | ||
| return f"{self.ALIAS[0]}" |
There was a problem hiding this comment.
这一行后面添加一下注释：”# pragma: no cover“可以跳过codecov的覆盖率检测，避免项目的覆盖率降低 PR不过~
rageval/models/tokenizer.py
Outdated
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class Tokenizer(ABC): |
There was a problem hiding this comment.
这个tokenizer只有一个__init__函数，就不用写成一个类了，感觉在用的时候直接实例调用就可以了
|
|
||
| ALIAS = ['text_length'] | ||
|
|
||
| def __init__(self, tokenize_model: str = "Qwen/Qwen2-0.5B-Instruct"): |
There was a problem hiding this comment.
感觉你这里是不是Tokenizer不用写一个类，直接在 class TextLength里面一个成员就好了
bugtig6351
requested changes
Sep 25, 2024
bugtig6351
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.