Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed to yapapi to make the package PEP 561 compliant #221

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

azawlocki
Copy link
Contributor

Resolves #197

See #197 for details.

@azawlocki azawlocki self-assigned this Jan 22, 2021
@azawlocki azawlocki requested a review from etam January 22, 2021 14:21
@etam
Copy link
Contributor

etam commented Jan 22, 2021

Is it installed by poetry?

In python-poetry/poetry#1338 (comment) they say you need to add to pyproject.toml

[tool.poetry]
include = ["mypackage/py.typed"]

@azawlocki
Copy link
Contributor Author

azawlocki commented Jan 22, 2021

Is it installed by poetry?

In python-poetry/poetry#1338 (comment) they say you need to add to pyproject.toml

[tool.poetry]
include = ["mypackage/py.typed"]

@etam Yes, it is. Attaching a .tgz build by poetry.
yapapi-0.5.0a2.tar.gz

EDIT: I've also installed yapapi from a wheel package built by poetry in a fresh virtualenv and made sure that py.typed was there and that mypy was able to typecheck blender.py.

Copy link
Contributor

@etam etam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

@azawlocki azawlocki merged commit 19c7be0 into master Jan 22, 2021
@azawlocki azawlocki deleted the feature/pep-561 branch January 22, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: make package PEP-561 compatible
2 participants