-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSB API OpenAPI #137
GSB API OpenAPI #137
Conversation
59d908c
to
8764077
Compare
8764077
to
cb1faa6
Compare
cb1faa6
to
cee6a1d
Compare
@stranger80 Please look at this specification update |
App -->> Backend: WS Event: Close<br>CloseCode: Abnormal | ||
end | ||
|
||
Note right of Backend: Canceling GSB request<br> on WS Close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to cancel pending GSB requests on WS close instead of buffering them because I assume this Close might have been caused by this GSB requests, so resending it could create a crash loop.
cee6a1d
to
42b863f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this precise specification.
Reviewed with some typos, one YAML update and big request to fillthe content of a dedicated GAP article (branch and PR have been added for convenience - golemfactory/golem-architecture#68)
Co-authored-by: stranger80 <stranger80@users.noreply.github.com>
requestBody instead of responses typo Co-authored-by: stranger80 <stranger80@users.noreply.github.com>
Method's |
Resolves golemfactory/yagna#2415