Payload manifest various cert formats #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evik42
approved these changes
Jan 22, 2023
| @@ -47,7 +47,7 @@ Digest algorithm used to generate manifest signature. | |||
|
|
|||
| ### `golem.srv.comp.payload.cert: String` | |||
|
|
|||
| Base64-encoded certificate in DER format. | |||
| Base64-encoded certificate in DER, PEM, or PEM certificate chain formats. | |||
There was a problem hiding this comment.
The wording is confusing for me, first I thought you added PEM twice then I realized that the third option is PEM certificate chain. Btw if certificates are supported with DER and PER encoding, then wouldn't it support certificate chains in DER encoding also?
Suggested change
| Base64-encoded certificate in DER, PEM, or PEM certificate chain formats. | |
| Base64-encoded string of a DER or PEM encoded certificate or PEM encoded certificate chain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAP mentiones specifically DER format while other formats are also supported.