Fix error when a play() call was interrupted by a call to pause() #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any plans on merging this? |
|
I'll get this merged shortly, thanks! For future reference, avoid modifying anything in |
|
I was trying to upgrade and this commit seems to be causing some issues in Safari. If I start playing, then seek, I get a 'Unhandled Promise Rejection: [object DOMError]' and can no longer pause. In 2.0.5 I get the same exception, but pause still works. Has anyone else run into this or have a workaround? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#718
Handled the case where this exception was thrown:
The error would occur when
audio.pause()andaudio.play()are called in rapid succession.Implemented a lock that prevents
audio.pause()from being executed when there is a pendingaudio.play()returned promise. The lock gets lifted and queued actions are executed after the promise has resolved.