Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix old opera detection for three digit version numbers (100+) #1676

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

bikubi
Copy link
Contributor

@bikubi bikubi commented Jul 31, 2023

Issue/Feature

Fixes mp3 playback on Opera v100+

Related Issues

#1670

Solution

The browser sniffing regex did not expect version numbers with three digits. 100 got misinterpreted as 10, which is less than the cut-off version 33.

We improve the regex.

Reproduction/Testing

You might not notice in all examples. Our application listens to loaderror. You can add that to the radio example.
Also update your Opera before testing...

Breaking Changes

N/A

note: contains also previous commits
dab32ba
f128f9d
@Cvolton
Copy link

Cvolton commented Sep 5, 2023

can confirm this PR fixes the issue, would be awesome if this got merged, so I could stop relying on using a fork in my application

@goldfire goldfire merged commit cf2969c into goldfire:master Sep 19, 2023
@goldfire
Copy link
Owner

Thanks for catching this! v2.2.4 is now live on npm with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants