Include keydown event when unlocking audio #1417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow users with accessibility issues use our site we needed to support "unlocking" Howler using non-click/touch based events. The
keydown
event seemed the most appropriate.I noticed there have been other discussions that have skirted around expanding on the existing list of events that trigger the unlock but I couldn't find anything concrete.
@oswaldofreitas mentioned in #1294 about using:
And @Jimbly appears to be listening for
https://github.com/Jimbly/howler.js/blob/master/src/howler.core.js#L433-L438
In the short term at least, adding
keydown
(and maybekeyup
?) would help with the accessibility issues.Great project BTW 👍