Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate: add clean-cache.chinese.md #1047

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

mattjin
Copy link
Collaborator

@mattjin mattjin commented Jul 16, 2021

No description provided.

Copy link
Collaborator

@rluvaton rluvaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!, I'll ask someone to review it 😀

<details>
<summary><strong>Dockerfile</strong></summary>

```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add dockerfile language here 😀

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rluvaton @mattjin After reviewing I noticed that, let's make this minor fix and merge. Thanks both! 💪

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rluvaton
Copy link
Collaborator

@goldbergyoni who do we have that can review it?

@goldbergyoni
Copy link
Owner

@rluvaton Matt is the author of the origin Chinese translation, he has 20% shares of this repo 😅

@mattjin

goldbergyoni
goldbergyoni previously approved these changes Jul 18, 2021
Copy link
Collaborator Author

@mattjin mattjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz have a check

@rluvaton
Copy link
Collaborator

Thank you so much

@rluvaton rluvaton merged commit d58e560 into goldbergyoni:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants