Skip to content

fix: don't hide typecheck errors inside diff processor #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2024
Merged

fix: don't hide typecheck errors inside diff processor #4674

merged 2 commits into from
Apr 24, 2024

Conversation

@ldez
Copy link
Member

@ldez ldez commented Apr 23, 2024 •
edited
Loading

The diff processor should never skip typecheck errors.

Fixes #4097

@ldez ldez added bug Something isn't working area: processors labels Apr 23, 2024
@ldez ldez added this to the next milestone Apr 23, 2024
@ldez ldez changed the title fix: the diff processor should not hide typecheck errors fix: don't hide typecheck errors inside diff processor Apr 24, 2024
@ldez ldez mentioned this pull request Apr 24, 2024
Closed
5 tasks
alexandear
alexandear approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a reproducible example to the description that demonstrates the problem?

@ldez
Copy link
Member Author

ldez commented Apr 24, 2024 •
edited
Loading

The example is inside the issue description #4097

#4097 (comment)

@ldez ldez merged commit c1f9f54 into golangci:master Apr 24, 2024
@ldez ldez deleted the fix/never-skip-typecheck branch April 24, 2024 12:54
@ldez ldez modified the milestones: next, v1.58 May 8, 2024
@ldez ldez mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandear alexandear alexandear approved these changes

Assignees

No one assigned

Labels

area: processors bug Something isn't working

Projects

None yet

Milestone

v1.58

Development

Successfully merging this pull request may close these issues.

--new-from-rev gets confused by merge commits

2 participants

@ldez @alexandear