fix: make versioning inside Docker image consistent with binaries #4279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
changed the title
ldez
requested changes
Dec 21, 2023
…h goreleaser build goreleaser currently strips the leading `v` off of the SemVer tag when passing to ldflags, while the container build does not remove it. Remove the leading `v`, if present, off of the version in container builds so that the version returned by `golangci-lint --version` is consistent regardless of whether the program is running standalone or in a container.
alebcay
force-pushed
the
docker-binary-versioning
branch
from
ae8af67 to
7f2ab2e
Compare
ldez
changed the title
ldez
added
bug
ldez
changed the title
ldez
approved these changes
Dec 22, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goreleaser currently strips the leading
voff of the SemVer tag when passing to ldflags, while the container build does not remove it.Remove the leading
v, if present, off of the version in container builds so that the version returned bygolangci-lint --versionis consistent regardless of whether the program is running standalone or in a container.As discussed in #4268.
Fixes #4263