Fix the skip-dirs option. #313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the SkipDir runner was not skipping files such as `foo/bar/baz.go` with a `skip-dir` entry of `foo/bar` when the `run` command was invoked with an argument of `foo/...`. This is both a surprising and problematic behavior change. The pathology was: 1. `shouldPassIssue()` was receiving an input like `foo/bar/baz.go` 2. `shouldPassIssue()` would call `p.getLongestArgRelativeIssuePath()` which was returning `bar`, not `foo/bar` as expected. 3. The reason for this was because inside of `getLongestArgRelativeIssuePath()` it was trimming the prefix that matched the path prefix (e.g. `foo/`). If you have the file structure: - foo/bar/baz.go - bur/bar/baz.go There is no way to isolate `foo/bar` from `bur/baz` without strictly controlling both your `skip-dirs` configuration and the arguments to `run`. The rest of the logic to skip files that don't match `run`'s argument is valid, however the regexp should be evaluated based on the `filepath.Dir()` of the input (e.g. `foo/bar`) and not the truncated version of the issue's filepath. Fixes: golangci#301
|
|
|
thank you! but tests don't pass, I will include your PR and fix it in #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the SkipDir runner was not skipping files such as
foo/bar/baz.gowith askip-direntry offoo/barwhen theruncommand was invoked with an argument offoo/.... This is both a surprising and problematic behavior change.The pathology was:
shouldPassIssue()was receiving an input likefoo/bar/baz.goshouldPassIssue()would callp.getLongestArgRelativeIssuePath()which was returningbar, notfoo/baras expected.getLongestArgRelativeIssuePath()it was trimming the prefix that matched the path prefix (e.g.foo/).If you have the file structure:
There is no way to isolate
foo/barfrombur/bazwithout strictly controlling both yourskip-dirsconfiguration and the arguments torun.The rest of the logic to skip files that don't match
run's argument is valid, however the regexp should be evaluated based on thefilepath.Dir()of the input (e.g.foo/bar) and not the truncated version of the issue's filepath.This fixed unexpected breakage resulting from a recent upgrade.
Fixes: #301