Skip to content

Conversation

@bvwells
Copy link
Contributor

@bvwells bvwells commented Nov 27, 2018

Fix typo in gometalinter comparison example.

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2018

CLA assistant check
All committers have signed the CLA.

@jirfag
Copy link
Contributor

jirfag commented Nov 27, 2018

thank you! I'm waiting for CLA to merge

@bvwells
Copy link
Contributor Author

bvwells commented Nov 27, 2018

No problems @jirfag!

@bvwells
Copy link
Contributor Author

bvwells commented Nov 27, 2018

@jirfag, it looks like golangci-lint also supports excludes on the command line (--exclude=<default golangci-lint excludes>). I was thinking about adding this to the gometalinter example comparison. What do you think?

@jirfag
Copy link
Contributor

jirfag commented Nov 28, 2018

these excludes are used by default, even without an explicit argument.

@jirfag jirfag merged commit ef78643 into golangci:master Nov 28, 2018
@bvwells
Copy link
Contributor Author

bvwells commented Nov 28, 2018

I see what you mean. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants