Add support for home directory expansion for -c/--config flag #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This change introduces the ability to use the tilde (`~`) character in your `-c/--config` flag value to expand your home directory. If invoking this via the command line with `--config ~/.golangci-lint.yaml`, the user's shell expands the `~` to the home directory. However, if something is invoking the program for you (like an editor) it may not do the expansion. Fixes golangci#289 Signed-off-by: Tim Heckman <t@heckman.io>
jirfag
approved these changes
Nov 14, 2018
|
thank you! |
|
@jirfag of course; and thank you for such a quick review/merge. 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to use the tilde (
~) character in your-c/--configflag value to expand your home directory. If invoking this via thecommand line with
--config ~/.golangci-lint.yaml, the user's shell expands the~to the home directory. However, if something is invoking the program foryou (like an editor) it may not do the expansion.
Fixes #289
Signed-off-by: Tim Heckman t@heckman.io
Thank you for the pull request!
Please make sure you didn't directly change
README.md: it should be changed only by changingREADME.tmpl.mdand runningmake readme.