fix #132: support go-critic linter #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Nov 5, 2018
jirfag
force-pushed
the
feature/support-gocritic
branch
3 times, most recently
from
d44048b to
56ee620
Compare
|
It's ready to merge. |
cristaloleg
approved these changes
Nov 5, 2018
jirfag
force-pushed
the
feature/support-gocritic
branch
from
56ee620 to
765e904
Compare
quasilyte
reviewed
Nov 6, 2018
pkg/golinters/gocritic.go
Outdated
| sizes := types.SizesFor("gc", runtime.GOARCH) | ||
| lintpackCtx := lintpack.NewContext(lintCtx.Program.Fset, sizes) | ||
|
|
||
| s := lintCtx.Settings().Gocritic // TODO: pass per-check settings |
There was a problem hiding this comment.
I believe this TODO can be removed now.
jirfag
force-pushed
the
feature/support-gocritic
branch
2 times, most recently
from
553502e to
18c9a74
Compare
jirfag
force-pushed
the
feature/support-gocritic
branch
from
18c9a74 to
e985614
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.