Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Remove completion subcommand #2107

Merged
merged 1 commit into from
Jul 7, 2021
Merged

cleanup: Remove completion subcommand #2107

merged 1 commit into from
Jul 7, 2021

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Jul 7, 2021 •
edited
Loading

Description

With #2105, completion subcommand will be automatically added. Consider
that golangci-lint didn't do anything special with completion, it's better
to just remove it from codebase.

Signed-off-by: Tam Mach sayboras@yahoo.com

Testing

Testing was done as per below

$ ./golangci-lint completion -h

Generate the autocompletion script for golangci-lint for the specified shell.
See each sub-command's help for details on how to use the generated script.

Usage:
  golangci-lint completion [command]

Available Commands:
  bash        generate the autocompletion script for bash
  fish        generate the autocompletion script for fish
  powershell  generate the autocompletion script for powershell
  zsh         generate the autocompletion script for zsh

@sayboras
cleanup: Remove completion subcommand
a03e5ea 
With golangci#2105, completion subcommand will be automatically added. Consider
that golangci-lint didn't do anything special with completion, it's better
to ust remove it from codebase.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
bombsimon
bombsimon approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Jul 7, 2021
@ldez ldez merged commit a6fcf6f into golangci:master Jul 7, 2021
@sayboras sayboras deleted the remove-completion branch July 7, 2021 12:17
@MarvinJWendt
Copy link

Hi @sayboras, why was the completion command removed? It's auto generated from all subcommands and flags, there is no need to "do anything special with completion", it "just works" :)

@ldez
Copy link
Member

ldez commented Jul 7, 2021

The completion command is still here, right now it's auto-generated.
We just removed the old code to generate manually the command.

@MarvinJWendt
Copy link

Oh okay I see, thanks @ldez.

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@sayboras @SeigeC
cleanup: Remove completion subcommand (golangci#2107)
c729873
@ldez ldez added this to the v1.42 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.42
Development

Successfully merging this pull request may close these issues.
4 participants
@sayboras @MarvinJWendt @ldez @bombsimon