gofumpt: Add lang-version option

[kailun-qin]

Without the Go language version input, gofumpt cannot apply some rules
which are version dependent.

Defaulting lang-version to the Go version of the running environment
if not specified.

Signed-off-by: Kailun Qin kailun.qin@intel.com

[boring-cyborg]

Hey, thank you for opening your first Pull Request !

[CLAassistant]

All committers have signed the CLA.

[ldez]

All the code related to format.Options must be moved outside the loop:

			settings := lintCtx.Settings().Gofumpt

			// Get the target Go language version to be used in gofumpt.
			// Reuse logic from `https://github.com/mvdan/gofumpt/blob/ba6406b58f3630c5246474b20f6ee5c83d1cc6b9/gofmt.go#L127-L133`.
			langVersion := settings.LangVersion
			if langVersion == "" {
				outGoVersion, errGoVersion := exec.Command("go", "list", "-m", "-f", "{{.GoVersion}}").Output()
				outGoVersion = bytes.TrimSpace(outGoVersion)
				if errGoVersion == nil && len(outGoVersion) > 0 {
					langVersion = string(outGoVersion)
				}
			}

			options := format.Options{
				LangVersion: langVersion,
				ExtraRules:  settings.ExtraRules,
			}

			var fileNames []string
			for _, f := range pass.Files {
				pos := pass.Fset.PositionFor(f.Pos(), false)
				fileNames = append(fileNames, pos.Filename)
			}

			var issues []goanalysis.Issue

			for _, f := range fileNames {
				input, err := ioutil.ReadFile(f)
				if err != nil {
					return nil, fmt.Errorf("unable to open file %s: %w", f, err)
				}

				output, err := format.Source(input, options)
				if err != nil {
					return nil, fmt.Errorf("error while running gofumpt: %w", err)
				}
				// ...
			}

[kailun-qin]

Good catch! Updated, thanks!

[bombsimon]

Good catch! Updated, thanks!

I think you can move it even further out, outside of analyzer.Run, no? I don't see why we need to figure out version and set options for every pass so doing it once should be enough, right @ldez?

[ldez]

@kailun-qin can you address changes as commit, because when you squash it's not possible to see changes.

I think you can move it even further out, outside of analyzer.Run, no?

@bombsimon it depends on the implementation to get the default Go version.

[kailun-qin]

@kailun-qin can you address changes as commit, because when you squash it's not possible to see changes.

Sorry that I didn't notice this before the latest commit. Will do for the followings.

I think you can move it even further out, outside of analyzer.Run, no?

@bombsimon it depends on the implementation to get the default Go version.

Using a hardcoding default (to 1.15) to remove the dependency, and IMO this can be moved outside of analyzer.Run. PTAL @bombsimon @ldez, thanks!

[bombsimon]

LGTM!

[ldez]

@kailun-qin please don't squash, we will squash when we will merge.

[kailun-qin]

@kailun-qin please don't squash, we will squash when we will merge.

@ldez Sure, excuse me for not catching your comment before refreshing the last commit. I'll not squash for the following ones.
Please kindly take a look at the latest version and see if any comment. Many thanks!

[kailun-qin]

Updated, thanks!

[ldez]

@kailun-qin just FYI https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes

[golangci-automator]

Hey, @kailun-qin — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

[kailun-qin]

@kailun-qin just FYI https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes

Thanks for the hint! I'll use that way for the future suggested changes.