docs: exhaustivestruct example explanation #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment add context on `struct-patterns` patterns, so its not unexpected for users that patterns behaves in next way: 1. e.g. `*.Text` can match struct Test if golangci-lint launched against the file `golangcli-lint run example/example.go` 1. e.g. `*.Text` do not match struct Test if golangci-lint launched against package `golangcli-lint run example`
butuzov
force-pushed
the
Fix-Exhaustivestruct
branch
from
12ca695
to
06e4045
Compare
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment add context on
struct-patternspatterns, so it's not unexpected for users that patterns behave in next way:e.g.
*.Textcan match struct Test if golangci-lint launched against the filegolangcli-lint run example/example.goe.g.
*.Textdo not match struct Test if golangci-lint launched against packagegolangcli-lint run example