Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: remove old TODO and remove assert import alias on require. #1838

Merged
merged 2 commits into from
Mar 13, 2021
Merged

dev: remove old TODO and remove assert import alias on require. #1838

merged 2 commits into from
Mar 13, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 13, 2021 •
edited
Loading

Handle old TODO:

	// TODO: uncomment after deprecating go1.11
	// assert.Equal(t, exitcodes.IssuesFound, exitErr.ExitCode())

Remove assert import alias on github.com/stretchr/testify/require:

import (
	assert "github.com/stretchr/testify/require"
)

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Mar 13, 2021
@butuzov butuzov self-requested a review March 13, 2021 03:19
@ldez ldez merged commit 9838a57 into golangci:master Mar 13, 2021
@ldez ldez deleted the fix/old-todo branch March 13, 2021 03:45
@ldez ldez added this to the v1.39 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butuzov butuzov butuzov approved these changes

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.39
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @butuzov