upgrade github.com/nishanths/exhaustive #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls in a fix for handling of blank identifiers by the exhaustive package. Patch obtained by running: go get github.com/nishanths/exhaustive
sayboras
reviewed
Jul 15, 2020
go.sum
Outdated
| @@ -261,6 +261,8 @@ github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWb | |||
| github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno= | |||
| github.com/nishanths/exhaustive v0.0.0-20200525081945-8e46705b6132 h1:NjznefjSrral0MiR4KlB41io/d3OklvhcgQUdfZTqJE= | |||
| github.com/nishanths/exhaustive v0.0.0-20200525081945-8e46705b6132/go.mod h1:wBEpHwM2OdmeNpdCvRPUlkEbBuaFmcK4Wv8Q7FuGW3c= | |||
There was a problem hiding this comment.
This is go.mod issue, which didn't clean up the old version.
If you want you can re-create go.sum files, so that old entries are removed.
There was a problem hiding this comment.
Did you mean edit go.sum by hand? I went ahead and added a commit that does that.
There was a problem hiding this comment.
Update: I see that go mod tidy does what's needed. I ran that instead.
There was a problem hiding this comment.
I meant that we can remove go.sum and run go mod tidy to recreate it again :).
There was a problem hiding this comment.
Awesome, thanks.
Running rm go.sum && go mod tidy didn't produce any more changes.
There was a problem hiding this comment.
this is one of the thing that I don't like with go mod :(
This was referenced Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in a fix for handling of blank identifiers by the exhaustive
package.
Patch obtained by running:
go get github.com/nishanths/exhaustive