Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting issues #1217

Closed
butuzov opened this issue Jul 7, 2020 · 2 comments
Closed

Sorting issues #1217

butuzov opened this issue Jul 7, 2020 · 2 comments
Labels
area: output Related to issue output enhancement New feature or improvement

Comments

@butuzov
Copy link
Member

butuzov commented Jul 7, 2020

Is your feature request related to a problem? Please describe.
It would be great to have sorted results by file/line/column. In case of similar checks, we can track issue as a group (see similarities in unused and deadcode example ), in case of different issues its can be useful to see what else linter found on/around same lines.

Describe the solution you'd like
Implement sort flag into the output config structure.

Additional context

Here is an example of the output without sorting (it's a little bit cut, but you got the idea).

main.go:19:6: `deadcode` is unused (deadcode)
main.go:10:2: S1021: should merge variable declaration with assignment on next line (gosimple)
main.go:19:6: func `deadcode` is unused (unused)

Here is an example of the output with sorting.

main.go:10:2: S1021: should merge variable declaration with assignment on next line (gosimple)
main.go:19:6: `deadcode` is unused (deadcode)
main.go:19:6: func `deadcode` is unused (unused)
@butuzov butuzov added the enhancement New feature or improvement label Jul 7, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 7, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@butuzov
Copy link
Member Author

butuzov commented Jul 7, 2020

If everything OK, I can add documentation and examples (once figure out how to do that).

@butuzov butuzov closed this as completed Jul 15, 2020
@ldez ldez added the area: output Related to issue output label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: output Related to issue output enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants