Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in go.mozilla.org/sops/v3: GHSA-x5c7-x7m2-rhmf #410

Closed
GoVulnBot opened this issue Mar 24, 2022 · 3 comments
Closed
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-x5c7-x7m2-rhmf, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
go.mozilla.org/sops/v3 3.7.1 < 3.7.1

See doc/triage.md for instructions on how to triage this report.

package: go.mozilla.org/sops/v3
versions:
  - introduced: v0.0.0
    fixed: v3.7.1
description: "### Impact\nWindows users using the sops direct editor option (`sops
    file.yaml`) can have a local executable named either `vi`, `vim`, or `nano` executed
    if running sops from `cmd.exe`\n\nThis attack is only viable if an attacker is
    able to place a malicious binary within the directory you are running sops from.
    As well, this attack will only work when using `cmd.exe` or the Windows C library
    [SearchPath function](https://docs.microsoft.com/en-us/windows/win32/api/processenv/nf-processenv-searchpatha).
    This is a result of these Windows tools including `.` within their `PATH` by default.\n\n**If
    you are using sops within untrusted directories on Windows via `cmd.exe`, please
    upgrade immediately** \n\n**As well, if you have `.` within your default $PATH,
    please upgrade immediately.**\n\nMore information can be found on the official
    Go blog: https://blog.golang.org/path-security\n\n### Patches\nThe problem has
    been resolved in v3.7.1\n\nNow, if Windows users using cmd.exe run into this issue,
    a warning message will be printed:\n`vim resolves to executable in current directory
    (.\\vim.exe)`\n\n### References\n* https://blog.golang.org/path-security\n\n###
    For more information\nIf you have any questions or comments about this advisory:\n*
    Open a discussion in [sops](https://github.com/mozilla/sops/discussions)"
published: 2021-05-20T16:50:34Z
last_modified: 2021-05-20T16:50:34Z
ghsas:
  - GHSA-x5c7-x7m2-rhmf

@neild
Copy link
Contributor

neild commented Jun 15, 2022

Vulnerability in tool.

@neild neild closed this as completed Jun 15, 2022
@neild neild added excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module. and removed NotGoVuln labels Aug 11, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592767 mentions this issue: data/reports: unexclude 50 reports

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/607218 mentions this issue: data/reports: unexclude 20 reports (16)

gopherbot pushed a commit that referenced this issue Aug 21, 2024
  - data/reports/GO-2022-0407.yaml
  - data/reports/GO-2022-0410.yaml
  - data/reports/GO-2022-0413.yaml
  - data/reports/GO-2022-0416.yaml
  - data/reports/GO-2022-0418.yaml
  - data/reports/GO-2022-0424.yaml
  - data/reports/GO-2022-0426.yaml
  - data/reports/GO-2022-0429.yaml
  - data/reports/GO-2022-0440.yaml
  - data/reports/GO-2022-0442.yaml
  - data/reports/GO-2022-0447.yaml
  - data/reports/GO-2022-0448.yaml
  - data/reports/GO-2022-0449.yaml
  - data/reports/GO-2022-0450.yaml
  - data/reports/GO-2022-0451.yaml
  - data/reports/GO-2022-0452.yaml
  - data/reports/GO-2022-0453.yaml
  - data/reports/GO-2022-0454.yaml
  - data/reports/GO-2022-0455.yaml
  - data/reports/GO-2022-0456.yaml

Updates #407
Updates #410
Updates #413
Updates #416
Updates #418
Updates #424
Updates #426
Updates #429
Updates #440
Updates #442
Updates #447
Updates #448
Updates #449
Updates #450
Updates #451
Updates #452
Updates #453
Updates #454
Updates #455
Updates #456

Change-Id: I206c09343a83edd1fd9f1a37410a59391d904c6d
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/607218
Reviewed-by: Damien Neil <dneil@google.com>
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module.
Projects
None yet
Development

No branches or pull requests

4 participants