You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See doc/triage.md for instructions on how to triage this report.
modules:
- module: TODO
versions:
- fixed: 1.4.0
packages:
- package: github.com/ory/hydra/oauth2
- module: TODO
versions:
- fixed: 1.4.0
packages:
- package: github.com/ory/hydra
description: "### Impact\n\nWhen using client authentication method \"private_key_jwt\"
[1], OpenId specification says the following about assertion `jti`:\n\n> A unique
identifier for the token, which can be used to prevent reuse of the token. These
tokens MUST only be used once, unless conditions for reuse were negotiated between
the parties\n\nHydra does not seem to check the uniqueness of this `jti` value.
Here is me sending the same token request twice, hence with the same `jti` assertion,
and getting two access tokens:\n\n```\n$ curl --insecure --location --request
POST 'https://localhost/_/oauth2/token' \\\n --header 'Content-Type: application/x-www-form-urlencoded'
\\\n --data-urlencode 'grant_type=client_credentials' \\\n --data-urlencode
'client_id=c001d00d-5ecc-beef-ca4e-b00b1e54a111' \\\n --data-urlencode 'scope=application
openid' \\\n --data-urlencode 'client_assertion_type=urn:ietf:params:oauth:client-assertion-type:jwt-bearer'
\\\n --data-urlencode 'client_assertion=eyJhb [...] jTw'\n{\"access_token\":\"zeG0NoqOtlACl8q5J6A-TIsNegQRRUzqLZaYrQtoBZQ.VR6iUcJQYp3u_j7pwvL7YtPqGhtyQe5OhnBE2KCp5pM\",\"expires_in\":3599,\"scope\":\"application
openid\",\"token_type\":\"bearer\"}⏎ ~$ curl --insecure --location
--request POST 'https://localhost/_/oauth2/token' \\\n --header 'Content-Type:
application/x-www-form-urlencoded' \\\n --data-urlencode 'grant_type=client_credentials'
\\\n --data-urlencode 'client_id=c001d00d-5ecc-beef-ca4e-b00b1e54a111' \\\n
\ --data-urlencode 'scope=application openid' \\\n --data-urlencode 'client_assertion_type=urn:ietf:params:oauth:client-assertion-type:jwt-bearer'
\\\n --data-urlencode 'client_assertion=eyJhb [...] jTw'\n{\"access_token\":\"wOYtgCLxLXlELORrwZlmeiqqMQ4kRzV-STU2_Sollas.mwlQGCZWXN7G2IoegUe1P0Vw5iGoKrkOzOaplhMSjm4\",\"expires_in\":3599,\"scope\":\"application
openid\",\"token_type\":\"bearer\"}\n```\n\n### Severity\n\nWe rate the severity
as medium because the following reasons make it hard to replay tokens without
the patch:\x10\n\n- TLS protects against MITM which makes it difficult to intercept
valid tokens for replay attacks\n- The expiry time of the JWT gives only a short
window of opportunity where it could be replayed\n\n### Patches\n\nThis will be
patched with v1.4.0+oryOS.17\n\n### Workarounds\n\nTwo workarounds have been identified:\n\n-
Do not allow clients to use `private_key_jwt`\n- Use short expiry times for the
JWTs\n\n### References\n\nhttps://openid.net/specs/openid-connect-core-1_0.html#ClientAuthentication\n\n###
Upstream\n\nThis issue will be resolved in the upstream repository https://github.com/ory/fosite"
cves:
- CVE-2020-5300
ghsas:
- GHSA-3p3g-vpw6-4w66
The text was updated successfully, but these errors were encountered:
In GitHub Security Advisory GHSA-3p3g-vpw6-4w66, there is a vulnerability in the following Go packages or modules:
See doc/triage.md for instructions on how to triage this report.
The text was updated successfully, but these errors were encountered: