src/goCover: clear cached coverage info on save #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for the regression in ms-vscode.Go@0.14.2 The `isDirty` bit of the TextDocument when vscode.workspace.onDidSaveTextDocument is already false. Adjust the condition for clearing cache not to check it. Modification should be tracked already by trackCodeCoverageRemovalOnFileChange. And let modifiedFiles start with an empty value rather than as undefined. Fixes github.com/microsoft/issues/3252.
googlebot
added
the
cla: yes
|
This PR (HEAD: fbfddd9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/234527 to see it. Tip: You can toggle comments from me using the |
kegsay
approved these changes
May 19, 2020
There was a problem hiding this comment.
As the original author of microsoft/vscode-go#2853 - this seems sensible.
|
This PR is being closed because golang.org/cl/234527 has been abandoned. applied directory to microsoft/vscode-go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the regression in ms-vscode.Go@0.14.2
The
isDirtybit of the TextDocument when vscode.workspace.onDidSaveTextDocument isalready false. Adjust the condition for clearing cache not to check it.
Modification should be tracked already by trackCodeCoverageRemovalOnFileChange.
And let modifiedFiles start with an empty value rather than as undefined.
Fixes microsoft/vscode-go#3252.