Skip to content

extension/src/goTest.ts: fix testFunctions filter #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vaniog
Copy link
Contributor

@vaniog vaniog commented Dec 25, 2024

Add conditional filtering for test functions based on provided
function name in _subTestAtCursor

Using functionName if it was provided as argument, otherwise
find any test function containing the cursor.

This change fixes a bug that previously required the cursor to be
within the parent function to run subtests.
Now, subtests can be executed even if the cursor is not positioned
in the parent function.

Copy link

google-cla bot commented Dec 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link
Collaborator

This PR (HEAD: b80819a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/638755.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 3: Code-Review+1 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 3:

Kokoro presubmit build queued for golang/vscode-go/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/92e1b27a-f4f4-419a-89a9-efe760041581


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/92e1b27a-f4f4-419a-89a9-efe760041581


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 3: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/92e1b27a-f4f4-419a-89a9-efe760041581


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 3: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 3: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Vaniog:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/638755.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 26, 2024
Add conditional filtering for test functions based on provided
function name in _subTestAtCursor

Using functionName if it was provided as argument, otherwise
find any test function containing the cursor.

This change fixes a bug that previously required the cursor to be
within the parent function to run subtests.
Now, subtests can be executed even if the cursor is not positioned
in the parent function.

Change-Id: I2667acb6bd5586664ea3b306112bfd9eaa54db76
GitHub-Last-Rev: b80819a
GitHub-Pull-Request: #3639
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/638755
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Commit-Queue: Ethan Reesor <ethan.reesor@gmail.com>
Reviewed-by: Ethan Reesor <ethan.reesor@gmail.com>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/638755 has been merged.

@gopherbot gopherbot closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants