Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

survey: enable by default #910

Closed
stamblerre opened this issue Nov 12, 2020 · 3 comments
Closed

survey: enable by default #910

stamblerre opened this issue Nov 12, 2020 · 3 comments
Labels
FrozenDueToAge
Milestone
v0.19.1

Comments

@stamblerre
Copy link
Contributor

We should turn on the gopls survey in the extension--not just the Nightly.
@hyangah, when do you think we'll be ready to do that?
@hyangah hyangah modified the milestones: v0.19.0, Backlog Nov 16, 2020
@hyangah hyangah modified the milestones: Backlog, v0.20.0 Nov 20, 2020
@hyangah
Copy link
Contributor

hyangah commented Nov 20, 2020

Some adjustments before enabling it by default:

  • Include whether the survey is from nightly or stable versions.
  • Include the gopls version.

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/275880 mentions this issue: src/goLanguageServer: enable user survey in stable version.

@hyangah hyangah modified the milestones: v0.20.0, v0.19.1 Dec 7, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/276216 mentions this issue: [release] src/goLanguageServer: enable user survey in stable version.

gopherbot pushed a commit that referenced this issue Dec 8, 2020
@hyangah
[release] src/goLanguageServer: enable user survey in stable version.
f663bea 
And, add gopls version and extension id to survey link to distinguish
results from nightly and stable extensions.

Adjust "showSurveyConfig' behavior for easier survey testing.
'Yes' try to prompt for survey, while 'Maybe' will try to run
the survey prompt config update (which maybe results in prompting
for survey).

Fixes #910

Change-Id: I5490620c3c17c6c71de8a9b9cf5e2b6e9a7c6e55
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/275880
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
(cherry picked from commit da0f1c6)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/276216
@golang golang locked and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
v0.19.1
Development

No branches or pull requests
3 participants
@hyangah @stamblerre @gopherbot