Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not prompting to install tools until the first Go file is opened #3038

Closed
thernstig opened this issue Nov 7, 2023 · 4 comments
Closed
Milestone

Comments

@thernstig
Copy link

Is your feature request related to a problem? Please describe.
Many of us are syncing VS Code extensions and settings between machines. Be that private, at work, or other hobby project machines. Not all machines are working on the same kind of projects, like Go.

But the Go extension is the only extension (out of tens and tens) that give this notification when starting a workspace:

The "gopls" command is not available. Run "go get -v golang.org/x/tools/gopls" to install.

This is annoying as I do not work on Go on all machines and do not wish to install the toolchain.

Describe the solution you'd like
I would like the notification to only be shown if/when I open a Golang file. It becomes less obtrusive.

Describe alternatives you've considered

Additional context
As far as I know, no other extension has this obtrusive notification each time i start VS Code.

@gopherbot gopherbot added this to the Untriaged milestone Nov 7, 2023
@findleyr
Copy link
Contributor

findleyr commented Nov 7, 2023

Thanks. I think this is related to #2164, but slightly different: we could activate the extension but not prompt to install missing tools until a Go file is opened.

@findleyr findleyr changed the title Do not Consider not prompting to install tools until the first Go file is opened Nov 7, 2023
@thernstig
Copy link
Author

@findleyr any reason to even activate the extension? I would guess it saves on resources, but more importantly on startup times. And VS Code in general strives to be snappy. Extensions doing their outmost to adhere to this helps all users.

@findleyr
Copy link
Contributor

findleyr commented Nov 8, 2023

@thernstig yes I think the simplest solution is #2164: just don't activate the extension.

Most other LSP clients (e.g. for vim or emacs) don't start the LSP session until the first go file is opened, and AFAIK this is fine.

@findleyr findleyr modified the milestones: Untriaged, vscode-go/backlog Nov 9, 2023
@hyangah hyangah modified the milestones: vscode-go/backlog, v0.41.0 Nov 22, 2023
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/545136 mentions this issue: package.json: remove 'workspaceContains' from activation events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants