Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: stable version of golang.go is marked as 'preview' #273

Closed
hyangah opened this issue Jun 30, 2020 · 2 comments
Closed

release: stable version of golang.go is marked as 'preview' #273

hyangah opened this issue Jun 30, 2020 · 2 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 30, 2020

package.json needs update.

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/240545 mentions this issue: package.json: unset the preview field, and prepare for 0.15.1 dev

@hyangah hyangah added this to the v0.15.1 milestone Jun 30, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/241162 mentions this issue: [release] package.json: unset the preview field, and prepare for 0.15.1 dev

gopherbot pushed a commit that referenced this issue Jul 7, 2020
Nightly version release process sets the preview field in the release workflow
(all.bash prepare_nightly). The default package.json is for golang.go
that shouldn't be marked as preview.

Fixes #273.

Change-Id: I7aee5208314c4eadb09abf67646c2ff64439e9ab
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240545
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
(cherry picked from commit 1be5ec9)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/241162
@golang golang locked and limited conversation to collaborators Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants