-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debug: show only user goroutines by default #1797
Comments
https://go-review.googlesource.com/c/vscode-go/+/359402 was submitted to enable this in Nightly |
Should we enable this in the stable release? |
Is there a way to enable this by default for all debugging sessions? 90% of my debugging is done via tests - I'd really like to be able to enable this when debugging a test, without having to create a launch.json entry for the test. |
Change https://go.dev/cl/534955 mentions this issue: |
Add a command to the callstack context menu that allows users to toggle between hiding and showing system goroutines. This allows for easier discovery of the feature. For #1797 Change-Id: I7f085d5e7d50ec3f3ae2a9d515c99b2e935c5d3a Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/534955 Commit-Queue: Suzy Mueller <suzmue@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@firelizzard18 sorry for the delay but adding the hideSystemGoroutines to the user settings in
Added the feature to be able to toggle the threads from the context menu: |
@suzmue Is there any extra work you planned to do during this cycle? cl/534955 made the feature accessible. |
Discussed in #1754
Originally posted by suzmue September 7, 2021
Using a debugger to debug a Go program reveals a lot of the Go runtime implementation details to the user. Several goroutines that belong to the runtime appear in the call stack, cluttering the view and making a simple program seem very complicated.
For example when debugging a simple hello world program, 5 different goroutines appear in the callstack:
Program stopped on a breakpoint in
main.go
:Call stack:
This proposal is to (by default) only show the user goroutines in the call stack. When using this new default, the call stack for hello world will only show a single goroutine, as would be expected from a simple program with no concurrency:
This would be controlled by a setting to allow users that really want to see the system goroutines to include them using the launch configuration.
The text was updated successfully, but these errors were encountered: