Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: dlv-dap installation instruction in the popup is incorrect #1395

Closed
hyangah opened this issue Apr 2, 2021 · 1 comment
Closed

debug: dlv-dap installation instruction in the popup is incorrect #1395

hyangah opened this issue Apr 2, 2021 · 1 comment
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 2, 2021

Screen Shot 2021-04-02 at 2 35 14 PM

For dlv-dap, we need to rename it to dlv-dap.
Or maybe we can just omit this and give a link to the manual instruction documentation.

cc @suzmue
@hyangah hyangah added Debug Issues related to the debugging functionality of the extension. DlvDAP labels Apr 2, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/307054 mentions this issue: src/goInstallTools.ts: update install instructions for dlv-dap

gopherbot pushed a commit that referenced this issue Apr 6, 2021
@suzmue @hyangah
src/goInstallTools.ts: update install instructions for dlv-dap
8e70c58 
Since dlv-dap is just dlv built at master and renamed, the standard
install instructions do not apply. Update to link to the documentation.

Also, look for dlv-dap tool instead of dlv when launching the dlv dap
process.

Updates #1395

Change-Id: I7639919594b1cbd753d09386794d0774f785122e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/307054
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@suzmue suzmue closed this as completed Apr 6, 2021
@golang golang locked and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hyangah @suzmue @gopherbot