internal/lsp/source: respond with the underlying type to Type Definition requests for composite types #292
Conversation
|
This PR (HEAD: 30acee4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/304789 to see it. Tip: You can toggle comments from me using the |
|
Message from Rebecca Stambler: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/304789. |
…ion requests for composite types Go to Type Definition works for all composite types except maps because it is not clear which type to return if both key and value are named types. Fixes golang/go#45029
ShoshinNikita
force-pushed
the
type-definition-for-composite-types
branch
from
30acee4 to
94a0481
Compare
|
This PR (HEAD: 94a0481) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/304789 to see it. Tip: You can toggle comments from me using the |
|
Message from Nikita Shoshin: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/304789. |
|
Message from Rebecca Stambler: Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/304789. |
|
Message from Go Bot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=78fe7dd6 Please don’t reply on this GitHub thread. Visit golang.org/cl/304789. |
|
Message from kokoro: Patch Set 3: Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/304789. |
|
Message from kokoro: Patch Set 3: gopls-CI+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/304789. |
|
Message from Go Bot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/304789. |
…ion requests for composite types Go to Type Definition works for all composite types except maps because it is not clear which type to return if both key and value are named types. Fixes golang/go#45029 Change-Id: Ie14f333c51af11033e2494aaaac367d35e7dc87b GitHub-Last-Rev: 94a0481 GitHub-Pull-Request: #292 Reviewed-on: https://go-review.googlesource.com/c/tools/+/304789 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>
|
This PR is being closed because golang.org/cl/304789 has been merged. |
Go to Type Definition works for all composite types except maps because
it is not clear which type to return if both key and value are named types.
Fixes golang/go#45029