-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/benchcmp: mention deprecation in docs #252
Conversation
This PR (HEAD: adc2bec) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/255878 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/255878. |
Message from Keith Randall: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/255878. |
This PR (HEAD: 8e19863) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/255878 to see it. Tip: You can toggle comments from me using the |
Message from Jiayu Yi: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/255878. |
Message from Keith Randall: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/255878. |
A deprecation notice was added to benchcmp in a1f8cf0, but there is no mention of it in the benchcmp docs at https://pkg.go.dev/golang.org/x/tools/cmd/benchcmp, so it may not be immediately obvious to new users. This PR adds the deprecation notice to the documentation as well to make it easier to discover. Change-Id: Ib49228abc140435023694173511caa4d3c6c0672 GitHub-Last-Rev: 8e19863 GitHub-Pull-Request: #252 Reviewed-on: https://go-review.googlesource.com/c/tools/+/255878 Reviewed-by: Keith Randall <khr@golang.org> Trust: Giovanni Bajo <rasky@develer.com>
This PR is being closed because golang.org/cl/255878 has been merged. |
A deprecation notice was added to benchcmp in a1f8cf0, but there is no mention of it in the benchcmp docs at https://pkg.go.dev/golang.org/x/tools/cmd/benchcmp, so it may not be immediately obvious to new users.
This PR adds the deprecation notice to the documentation as well to make it easier to discover.