Skip to content

Commit

Permalink
[gopls-release-branch.0.16] all: disable tests incompatible with CL 6…
Browse files Browse the repository at this point in the history
…03895

The tests disabled in this CL depend on being able to downgrade Go
versions to versions earlier than Go 1.21. This behavior will change
with CL 603895. Disable these tests for now and re-enable them with
fixes in a later CL.

For golang/go#68658

Change-Id: I13bdc03117989a128d90195ac90b2905102d293f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/604817
Commit-Queue: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Tim King <taking@google.com>
Auto-Submit: Michael Matloob <matloob@golang.org>
(cherry picked from commit 7f262d6)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/609416
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Bypass: Robert Findley <rfindley@google.com>
  • Loading branch information
matloob authored and findleyr committed Aug 29, 2024
1 parent 5b32599 commit 7a12077
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions go/analysis/passes/loopclosure/loopclosure_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ func Test(t *testing.T) {
}

func TestVersions22(t *testing.T) {
t.Skip("Disabled for golang.org/cl/603895. Fix and re-enable.")
testenv.NeedsGo1Point(t, 22)

txtar := filepath.Join(analysistest.TestData(), "src", "versions", "go22.txtar")
Expand All @@ -32,6 +33,7 @@ func TestVersions22(t *testing.T) {
}

func TestVersions18(t *testing.T) {
t.Skip("Disabled for golang.org/cl/603895. Fix and re-enable.")
txtar := filepath.Join(analysistest.TestData(), "src", "versions", "go18.txtar")
dir := testfiles.ExtractTxtarFileToTmp(t, txtar)
analysistest.Run(t, dir, loopclosure.Analyzer, "golang.org/fake/versions")
Expand Down
1 change: 1 addition & 0 deletions go/analysis/passes/stdversion/stdversion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
)

func Test(t *testing.T) {
t.Skip("Disabled for golang.org/cl/603895. Fix and re-enable.")
// The test relies on go1.21 std symbols, but the analyzer
// itself requires the go1.22 implementation of versions.FileVersions.
testenv.NeedsGo1Point(t, 22)
Expand Down
4 changes: 2 additions & 2 deletions go/ssa/interp/interp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ var testdataTests = []string{
"deepequal.go",
"defer.go",
"fieldprom.go",
"forvarlifetime_old.go",
// "forvarlifetime_old.go", Disabled for golang.org/cl/603895. Fix and re-enable.
"ifaceconv.go",
"ifaceprom.go",
"initorder.go",
Expand All @@ -129,7 +129,7 @@ var testdataTests = []string{
"slice2arrayptr.go",
"static.go",
"width32.go",
"rangevarlifetime_old.go",
// "rangevarlifetime_old.go", Disabled for golang.org/cl/603895. Fix and re-enable.
"fixedbugs/issue52342.go",
"fixedbugs/issue55115.go",
"fixedbugs/issue52835.go",
Expand Down
1 change: 1 addition & 0 deletions internal/testfiles/testfiles_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
)

func TestTestDir(t *testing.T) {
t.Skip("Disabled for golang.org/cl/603895. Fix and re-enable.")
testenv.NeedsGo1Point(t, 22)

// TODO(taking): Expose a helper for this pattern?
Expand Down

0 comments on commit 7a12077

Please sign in to comment.