-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#24775. Windows Service does not stop issue fixed #9
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
This PR (HEAD: 3010eeb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/sys/+/105795 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. |
Message from Brad Fitzpatrick: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. |
Please merge this PR |
@emli, we're still waiting on @azretkenzhaliev to address the review feedback. |
Message from Alex Brainman: Patch Set 1: azretkenzhaliev I don't see what the problem in issue #24775 is. Please reply to my questions at golang/go#24775 (comment) before I will review this CL. Thank you. Alex Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. |
Message from Gerrit User 5065: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. |
Message from Alex Brainman: Patch Set 1: azretkenzhaliev I don't see what the problem in issue #24775 is. Please reply to my questions at golang/go#24775 (comment) before I will review this CL. Thank you. Alex Please don’t reply on this GitHub thread. Visit golang.org/cl/105795. |
Closes #24775.