Skip to content

windows: add Recvfrom and Sendto implementations #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

windows: add Recvfrom and Sendto implementations #46

wants to merge 1 commit into from

Conversation

maltalex
Copy link
Contributor

@maltalex maltalex commented Nov 21, 2019

Added the missing Sendto and Recvfrom syscalls for Windows.
Fixes golang/go#7170

@gopherbot
Copy link
Contributor

This PR (HEAD: 39ebe92) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/208321 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

@maltalex
Copy link
Contributor Author

For your reviewing pleasure, documentation of these syscalls - sendto, recvfrom

@bradfitz bradfitz changed the title Added Recvfrom and Sendto implementations for Windows windows: add Recvfrom and Sendto implementations for Windows Nov 21, 2019
@bradfitz bradfitz changed the title windows: add Recvfrom and Sendto implementations for Windows windows: add Recvfrom and Sendto implementations Nov 21, 2019
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Run-TryBot+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=10f0a883


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Maltinsky:

Patch Set 3:

Patch Set 2: Run-TryBot+1

(2 comments)

I missed the part in the contribution guide where it said that the GitHub PR description would become part of the commit message when migrated to Gerrit. The original commit message is a one-liner.

How would I go about changing the commit message here? I'm getting a 403 when I try to edit the commit message in Gerrit.


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alex Maltinsky:

Patch Set 5:

(2 comments)

Apparently syncing from GitHub just took a while.
The commit message is now fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 5: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=7975c8cc


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/208321.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 28, 2019
Added the missing `Sendto` and `Recvfrom` syscalls for Windows.
Fixes golang/go#7170

Change-Id: I794b4f631fad424400fec85ccecc3a3b3abe5465
GitHub-Last-Rev: 39ebe92
GitHub-Pull-Request: #46
Reviewed-on: https://go-review.googlesource.com/c/sys/+/208321
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/208321 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/sys/windows: Windows does not implement Sendmsg, Recvmsg
3 participants