-
Notifications
You must be signed in to change notification settings - Fork 606
unix: fix Listen on solaris #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
libsocket has __xnet_listen, not __xnet_llisten
|
This PR (HEAD: 6f37c4b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/691735. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from 나지원: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from 나지원: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Jes Cok: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-08-30T13:55:17Z","revision":"6cdbc9cb8eb427b77e5cd93b89e93bdb45b147e1"} Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Jes Cok: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Keith Randall: Patch Set 2: Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Keith Randall: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Jes Cok: Patch Set 2: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Tobias Klauser: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Emmanuel Odeke: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from 나지원: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from 나지원: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Tobias Klauser: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-05T12:40:59Z","revision":"d212f0a6ba800a9343d34ecb6326a89b62afec57"} Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Tobias Klauser: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
|
Message from Emmanuel Odeke: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/691735. |
libsocket has __xnet_listen, not __xnet_llisten which prevents listen from working. Change-Id: Ia06dc569fcb9950893d91fc1b86257c7742e9e3d GitHub-Last-Rev: 6f37c4b GitHub-Pull-Request: #258 Reviewed-on: https://go-review.googlesource.com/c/sys/+/691735 Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Jes Cok <xigua67damn@gmail.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
|
This PR is being closed because golang.org/cl/691735 has been merged. |
libsocket has __xnet_listen, not __xnet_llisten
which prevents listen from working.