Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Registry Standard Access Rights #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s3cst4rs
Copy link

The description of registry access rights in MSDN is divided into two categories: standard access rights and specific access rights.

https://learn.microsoft.com/en-us/windows/win32/sysinfo/registry-key-security-and-access-rights
image

If standard access permissions are not supported, access will be denied due to excessive application permissions during use.

for example:

The access permissions of keys in HKLM are very limited, they are all readable, but other permissions are not sure.

For the permissions of the administrators group, there are special permissions in addition to read-only.
image

The following are the permissions of special permissions.
image

When I want to delete the key in HKLM, I can only choose KEY_SET_VALUE (Required to create, delete, or set a registry value.) in the code at present, but there is no create and set permission at present, and it will return Access is denied.

But if you only use the delete permission, there will be no problem.

image

image

@google-cla
Copy link

google-cla bot commented Jan 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gopherbot
Copy link

This PR (HEAD: deb67e9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/461085 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/461085.
After addressing review feedback, remember to publish your drafts!

@s3cst4rs
Copy link
Author

And API RegDeleteTreeA needs standard access rights: DELETE

https://learn.microsoft.com/en-us/windows/win32/api/winreg/nf-winreg-regdeletetreea
image

@gopherbot
Copy link

Message from Alex Brainman:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/461085.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants