oneof: generated code uses pointers for non-primitive types

[tamird]

See:

protobuf/proto/testdata/test.pb.go

Line 2031 in 535a104

Msg *Strings `protobuf:"bytes,10,opt,name=msg,oneof"`

There's no need for this to be a pointer, since the union interface is implemented for a pointer of the wrapping struct. The downside of using a pointer here is that it results in an additional allocation.

[dsymonds]

While what you say is true, it's a pointer for symmetry with all the other occurrences of messages.

[awalterschulze]

Please just think about this for another few seconds before dismissing this.

[atombender]

This should be reopened and addressed.