Skip to content

jsonpb: fix unmarshal tests to not compare using strings from proto.MarshalTextString #405

Closed
@cybrcodr

Description

@cybrcodr

Current unmarshaling tests calls proto.MarshalTextString and compares the resulting string. This is not a good comparison since MarshalTextString may not reflect the actual underlying data, e.g. nil vs empty slice. It's better to just use proto.Equal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions