oauth2: add device flow support #545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes various small errors, possibly due to changes betweend the
device flow draft and the final RFC.
Also includes a fix to avoid being stuck in an endless poll when
the token endpoint does not return a well-formed, expected error.
The following is the example response payload in RFC8628:
HTTP/1.1 200 OK
Content-Type: application/json
Cache-Control: no-store
{
"device_code": "GmRhmhcxhwAzkoEqiMEg_DnyEysNkuNhszIySk9eS",
"user_code": "WDJB-MJHT",
"verification_uri": "https://example.com/device",
"verification_uri_complete":
"https://example.com/device?user_code=WDJB-MJHT",
"expires_in": 1800,
"interval": 5
}
Using `json:"expires_in,string"` causes issues when an unquoted int
is encountered.
|
Brilliant timing. I just checked Golang for support of the device flow today. |
I encountered some bugs while testing this code, @anderspitman. Please let me know if you encounter any unexpected behaviour. I'll try to write some tests this weekend. |
|
@marcusirgens unfortunately I'm implementing a custom OAuth2 server, so I might wait until this is stable before using it, and might not be much help in testing. But if I do end up giving it a try I'll let you know. |
|
Implemented in e3fb0fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves merge conflicts in #356.
Also fixes some issues:
expires_inandintervalproperties in the Device Authorization ResponseResolves #418.