Skip to content

html: avoid endless loop on error token #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

html: avoid endless loop on error token #226

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cef851
fix net/html oom
yincongcyincong Nov 4, 2024
9f9c09f
add unit test
yincongcyincong Nov 4, 2024
76cab63
fix unit test
yincongcyincong Nov 5, 2024
a601ecd
optimize
yincongcyincong Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions html/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,11 @@ func afterHeadIM(p *parser) bool {
case DoctypeToken:
// Ignore the token.
return true
case ErrorToken:
// Stop parsing.
p.parseImpliedToken(StartTagToken, a.Body, a.Body.String())
p.framesetOK = true
return true
}

p.parseImpliedToken(StartTagToken, a.Body, a.Body.String())
Expand Down
1 change: 1 addition & 0 deletions html/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,7 @@ func TestParseFragmentForeignContentTemplates(t *testing.T) {
srcs := []string{
"<math><html><template><mn><template></template></template>",
"<math><math><head><mi><template>",
"<svg><head><title><select><input>",
}
for _, src := range srcs {
// The next line shouldn't infinite-loop.
Expand Down