-
Notifications
You must be signed in to change notification settings - Fork 791
bind: added protocol documentation to Objective-C generated file #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: b8065dd) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/331429 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
…otocol_documentation
This PR (HEAD: a69382c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/331429 to see it. Tip: You can toggle comments from me using the |
Message from Hyang-Ah Hana Kim: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Go Bot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Go Bot: Patch Set 3: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
This PR (HEAD: 175fa08) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/mobile/+/331429 to see it. Tip: You can toggle comments from me using the |
Message from Hyang-Ah Hana Kim: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Go Bot: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Go Bot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Hyang-Ah Hana Kim: Patch Set 4: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Hajime Hoshi: Patch Set 4: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Hilário Coelho: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Hyang-Ah Hana Kim: Patch Set 6: Patch Set 5 was rebased Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Hyang-Ah Hana Kim: Patch Set 6: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Gopher Robot: Patch Set 6: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Message from Michael Knyszek: Patch Set 6: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/331429. |
Fixes golang/go#46956 Change-Id: Ifa1b8e7f2a0e46034f0eccc32249f69a064199e3 GitHub-Last-Rev: 175fa08 GitHub-Pull-Request: #67 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/331429 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This PR is being closed because golang.org/cl/331429 has been merged. |
Fixes golang/go#46956