-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/printer: don't strip parens around *ast.Ellipsis in return field list #70266
base: master
Are you sure you want to change the base?
go/printer: don't strip parens around *ast.Ellipsis in return field list #70266
Conversation
Change-Id: Ic6a6d87202f9b531a591dc0ab2ef5fb050251198
This PR (HEAD: f1f04d3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626758. Important tips:
|
Change-Id: If10974dd4c44396f553d1581773e37f045a7d224
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
This PR (HEAD: 05e596c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626758. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-09T11:32:24Z","revision":"6dcb6d25b0e6767315cc50bd6eb0d13ff18b6d84"} Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Message from Mateusz Poliwczak: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Message from Matthew Dempsky: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Message from Mateusz Poliwczak: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Message from Matthew Dempsky: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Message from Mateusz Poliwczak: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626758. |
Before this change:
func A() (...A)
was formatted into:
func A() ...A
which causes a parse error.
With this change it is going to be formatted as (no change):
func A() (...A)