-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: use stringslite package for string operations #67461
Conversation
- Replace manual string suffix removal with stringslite.TrimSuffix in conf.go - Use stringslite.Cut for string splitting in ParseCIDR function in ip.go - Add stringslite import in ip.go This change simplifies string operations and improves code readability.
This PR (HEAD: aef5dc5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586157. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
Message from Zhen Li: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
Message from qiu laidongfeng2: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-17T06:26:48Z","revision":"1339fa28fa0d39b55e02cb45393743ed15d3d8f9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
Message from qiu laidongfeng2: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
Message from Damien Neil: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
Message from Dmitri Shuralyov: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586157. |
- Replace manual string suffix removal with stringslite.TrimSuffix in conf.go - Use stringslite.Cut for string splitting in ParseCIDR function in ip.go - Add stringslite import in ip.go This change simplifies string operations and improves code readability. Change-Id: I02c238d0bc91e95789d8060e6ef4c7d4f6e3f0d9 GitHub-Last-Rev: aef5dc5 GitHub-Pull-Request: #67461 Reviewed-on: https://go-review.googlesource.com/c/go/+/586157 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org> Commit-Queue: Ian Lance Taylor <iant@golang.org> Reviewed-by: Damien Neil <dneil@google.com>
This PR is being closed because golang.org/cl/586157 has been merged. |
This change simplifies string operations and improves code readability.