net: add Unwrap to *DNSError #63348

mateusz834 · 2023-10-03T09:30:23Z

Fixes #63116

gopherbot · 2023-10-03T09:42:06Z

This PR (HEAD: da0a95c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-03T09:50:30Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T09:50:31Z

Message from Mateusz Poliwczak:

Patch Set 1: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T09:58:59Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T09:59:11Z

This PR (HEAD: 253d311) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-03T10:07:59Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T10:08:00Z

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T10:08:01Z

Message from Mateusz Poliwczak:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T10:16:22Z

Message from Gopher Robot:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T10:24:56Z

Message from Mateusz Poliwczak:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T10:24:57Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T14:22:04Z

Message from Ian Lance Taylor:

Patch Set 2: Hold+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-03T14:22:05Z

Message from Mateusz Poliwczak:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-29T16:59:07Z

This PR (HEAD: 85203d1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-29T17:11:40Z

This PR (HEAD: 664ec4a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-29T17:24:19Z

This PR (HEAD: 77b7e03) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-29T17:37:17Z

Message from Mateusz Poliwczak:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-29T17:37:17Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-29T17:26:35Z","revision":"aaa3cf23ffa8a852daefcc8d24d98dfb5441f0df"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-29T17:55:04Z

Message from Mateusz Poliwczak:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-29T17:55:05Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-29T17:55:05Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-03T17:40:11Z

This PR (HEAD: 5d749a1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-03T17:53:55Z

This PR (HEAD: e62a00d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-05T16:32:06Z

Message from Damien Neil:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-05T17:22:45Z

This PR (HEAD: c891739) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-05T17:29:18Z

This PR (HEAD: ad8cf13) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-05T17:41:57Z

Message from Mateusz Poliwczak:

Patch Set 9: Commit-Queue+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-05T17:41:58Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-05T17:36:01Z","revision":"84bd3ebb8bc302adfac1ad3d595ff4db402e89bb"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

Change-Id: Ifb42782633d83270784747aca7fc075af5c478f9

Change-Id: I4c27df3708b3dc48c7c831a710e39027e3bd91f6

Change-Id: I4354271c8c631f260485ff8a0e2f48d1ab8b9a5f

Change-Id: Ibf2dc2fa5d5633e1cd36285421dc8977d448727c

Change-Id: Id2f650ed6205de5dd3fdf955d0521be041c16afe

Change-Id: Ie062c12f7ab4d6e277177d044e87e0844d8698f6

Change-Id: I4e2f18d03cd3565acb044b6d8d19ddb3cfb6c20e

Change-Id: Ib1c6bc394727b5fd1e1d4dd10bdf84fe0060e58e

Change-Id: Ibcf947474c3b5c993ee297f79419770d7b0b4032

Change-Id: If1a2b54a55e1175c7157b007e8c6177062a38966

Change-Id: Ib7f18566e38080726685794ccf2393af292aab87

Change-Id: Ib8e73ff00beb499f9fac8d0d17a6f65b65d2536e

Change-Id: I356a240f5fba2e2320b6bd330e6e9a7ad75043f4

Change-Id: Ib2b83fe7c56e6b3eb835b4b8861c8f3e8e3d1f94

Change-Id: Ib21b1f52eb5d3d3f01e632b75da81553270e1a25

Change-Id: Ic1de18388240534f27edc612e8bc12cf84951c76

Change-Id: Ief670a566422295e8437cf0e49821c57b813bf03

Change-Id: Ie97323c886c5e1f40db1a39701464a9799635d13

Change-Id: Ib2ffbc1d77c82ed3d32c660d53b5cec741936cb2

Change-Id: I6bbe3a3efa2072a770261e13adc396f95b1c21d4

gopherbot · 2024-04-13T07:01:47Z

This PR (HEAD: 8a8177b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/532217.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-13T07:07:42Z

Message from Mateusz Poliwczak:

Patch Set 19: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-13T07:13:34Z

Message from Go LUCI:

Patch Set 19:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-13T07:02:16Z","revision":"4156ab6f31756cc5e10b533c8c7579bb6848acb5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-13T07:31:07Z

Message from Mateusz Poliwczak:

Patch Set 19: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-13T07:31:07Z

Message from Go LUCI:

Patch Set 19:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-13T07:31:08Z

Message from Go LUCI:

Patch Set 19: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/532217.
After addressing review feedback, remember to publish your drafts!

Fixes #63116 Change-Id: Iab8c415555ab85097be6d2d133b3349c5219a23b GitHub-Last-Rev: 8a8177b GitHub-Pull-Request: #63348 Reviewed-on: https://go-review.googlesource.com/c/go/+/532217 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Damien Neil <dneil@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Commit-Queue: Ian Lance Taylor <iant@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2024-04-14T18:26:46Z

This PR is being closed because golang.org/cl/532217 has been merged.

mateusz834 force-pushed the net-dnserr-unwrap branch from 6af41ed to da0a95c Compare October 3, 2023 09:36

mateusz834 force-pushed the net-dnserr-unwrap branch from 253d311 to c5f0fa8 Compare March 29, 2024 16:55

mateusz834 added 20 commits April 13, 2024 08:57

net: add Unwrap to *DNSError

ebb89a7

Change-Id: Ifb42782633d83270784747aca7fc075af5c478f9

don't wrap all errors

773b3e4

Change-Id: I4c27df3708b3dc48c7c831a710e39027e3bd91f6

update comment

3382fdd

Change-Id: I4354271c8c631f260485ff8a0e2f48d1ab8b9a5f

add api file

ca9bbda

Change-Id: Ibf2dc2fa5d5633e1cd36285421dc8977d448727c

revert error change

c57fcd5

Change-Id: Id2f650ed6205de5dd3fdf955d0521be041c16afe

add relnote

f3b7e6c

Change-Id: Ie062c12f7ab4d6e277177d044e87e0844d8698f6

use Error interface

a61c07b

Change-Id: I4e2f18d03cd3565acb044b6d8d19ddb3cfb6c20e

add temporaryError

745ff94

Change-Id: Ib1c6bc394727b5fd1e1d4dd10bdf84fe0060e58e

update relnote

7cfd52a

Change-Id: Ibcf947474c3b5c993ee297f79419770d7b0b4032

don't always call newWrappingDnsError

6c66153

Change-Id: If1a2b54a55e1175c7157b007e8c6177062a38966

remove global error

5207d30

Change-Id: Ib7f18566e38080726685794ccf2393af292aab87

typo

e987040

Change-Id: Ib8e73ff00beb499f9fac8d0d17a6f65b65d2536e

update test

eafc4e8

Change-Id: I356a240f5fba2e2320b6bd330e6e9a7ad75043f4

rename to newDNSError

5517e7e

Change-Id: Ib2b83fe7c56e6b3eb835b4b8861c8f3e8e3d1f94

update

ea68a9c

Change-Id: Ib21b1f52eb5d3d3f01e632b75da81553270e1a25

update

065814f

Change-Id: Ic1de18388240534f27edc612e8bc12cf84951c76

fix

df21a22

Change-Id: Ief670a566422295e8437cf0e49821c57b813bf03

fix 2

d13d6d0

Change-Id: Ie97323c886c5e1f40db1a39701464a9799635d13

add test and docs

3643528

Change-Id: Ib2ffbc1d77c82ed3d32c660d53b5cec741936cb2

move goResolver

8a8177b

Change-Id: I6bbe3a3efa2072a770261e13adc396f95b1c21d4

mateusz834 force-pushed the net-dnserr-unwrap branch from 4d3720c to 8a8177b Compare April 13, 2024 06:57

gopherbot closed this Apr 14, 2024

net: add Unwrap to *DNSError #63348

net: add Unwrap to *DNSError #63348

Conversation

mateusz834 commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Oct 3, 2023

gopherbot commented Mar 29, 2024

gopherbot commented Mar 29, 2024

gopherbot commented Mar 29, 2024

gopherbot commented Mar 29, 2024

gopherbot commented Mar 29, 2024

gopherbot commented Mar 29, 2024

gopherbot commented Mar 29, 2024

gopherbot commented Mar 29, 2024

gopherbot commented Apr 3, 2024

gopherbot commented Apr 3, 2024

gopherbot commented Apr 5, 2024

gopherbot commented Apr 5, 2024

gopherbot commented Apr 5, 2024

gopherbot commented Apr 5, 2024

gopherbot commented Apr 5, 2024

gopherbot commented Apr 13, 2024

gopherbot commented Apr 13, 2024

gopherbot commented Apr 13, 2024

gopherbot commented Apr 13, 2024

gopherbot commented Apr 13, 2024

gopherbot commented Apr 13, 2024

gopherbot commented Apr 14, 2024